Review main Merged

70207[BUGFIX] Only minifyJS once in Frontend

Benni Mack CR +2 V +2 Normal +13 −41 updated 08/05/21, 18:52

Commit message

If you have inline JS (or inlineFooterJS) code
the method "GeneralUtility::minifyJavaScript()"
is called twice for the same code to actually minify
the code, because PageRenderer takes
care of minification, so FE process does not
explicitly have to do that.

This does no harm, only if there is a hook
within minifyJavaScript(), the processing is triggered
twice. This also only happens if config.compressJs = 1
is called.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1