Review main Merged

70236[TASK] Deprecate GeneralUtility::minifyJavaScript()

Benni Mack CR +2 V +2 Normal +80 −29 updated 09/17/21, 10:08

Commit message

The method "GeneralUtility::minifyJavaScript()"
was introduced back in 2007 when TYPO3 used
"jsmin". Then, the hook was introduced, and
"jsmin" was removed from TYPO3 Core again.

TYPO3 Core also added - in parallel - the concept
of the PageRenderer, which also contains a hook for
extensions (such as EXT:min), or then calls the
ResourceCompressor, which takes care of compressing
and concatenating resources.

The hook is now moved from GeneralUtility and executed
within the ResourceCompressor, so extensions
can still use the hook to compress inline JavaScript.

However, the method is completely mis-placed nowadays
and is moved to the according place in ResourceCompressor.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6