Review main Merged

70240[TASK] Cleanup Clipboard component

Oli Bartsch CR +2 V +2 Hard +446 −470 updated 08/09/21, 08:12

Commit message

In our effort to improve the UX in the record- and
filelist, the clipboard component will receive some
improvements in upcoming patches. For example the
clipboard panel should be a standalone web component,
listening on events, so it could be used in any module.

However, to be able to do so, the Clipboard class
needs to be cleaned up first. Therefore, among other,
this patch does the following:

* Add strict types, type hints and resolve "mixed"
  types, e.g some arguments accepted bool|int instead
  of just bool, while they are just treated as bool.
* Improve naming of used variables
* Simplify some code parts
* Add guard clauses where applicable
* Move the DataHandler command array generation into
  the classes (SimpleDataHandler, FileController), they
  belong to
* Protect methods, only intended for the use in Clipboard
* Remove fileMode property since most of the code already
  explicitly checked for the given table anyways

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7