Review main Merged

70244[TASK] Run Grunt scripts in parallel

Andreas Kienast CR +2 V +2 Normal +108 −36 updated 08/31/21, 11:06

Commit message

This patch groups Grunt tasks that can run simultaneously to improve the
build performance. To achieve this, the package `grunt-concurrent` is
used.

On a 2018 Dell XPS 15 with Intel i7-9750H this saves roughly 12 seconds.
To check the difference, the command `time grunt build` was executed
twice:

Sequential build:

  48,09s user 10,06s system 154% cpu 37,565 total
  50,60s user 11,89s system 154% cpu 40,539 total

Parallel build:

  77,91s user 5,96s system 261% cpu 28,311 total
  67,43s user 5,05s system 262% cpu 27,619 total

Due to issues with `grunt-contrib-imagemin`, the subscript `imagemin` is
excluded from the `minify_assets` group for now.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3