Review main Merged

70277[TASK] Remove docBlockChecker integrity test

Christian Kuhn CR +2 V +2 Hard +0 −355 updated 08/06/21, 18:43

Commit message

We have the annotationChecker and the ever growing
phpstan ruleset that scan our codebase for code and
documentation code block violations.

For the additional script docBlockChecker.php it's
unclear what it actually does and when it should fail.
It never went red to my knowledge. The patch author
didn't know what was going on and I've been unable to
make the script fail with local tests. The mentioned
phpdocumentor/phpdocumentor seems to have never
materialized in our world, and tools like api.typo3.org
rely on doxygen.

The patch drops that integrity test script and removes
usages in runTests.sh and gitlab-ci.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5