Review main Merged

70285[TASK] Clean up ErrorHandler

Benni Mack CR +2 V +2 Hard +310 −54 updated 08/14/21, 10:41

Commit message

The error handler now uses LogLevel
constants in various places, except for sys_log
where the severity is manually resolved.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • crell +1
    • Anja Leichsenring +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1317

  1. Benni Mack uploaded patch set 1 08/08/21, 09:13

  2. Benni Mack commented on patch set 2 08/08/21, 09:20

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 08/08/21, 09:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14264

  4. core-ci voted on patch set 2 V +1 08/08/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14265

  5. Benni Mack uploaded patch set 3 08/10/21, 14:33

  6. core-ci voted on patch set 3 V +1 08/10/21, 14:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14491

  7. Benni Mack updated the commit message in patch set 4 08/10/21, 14:54

  8. Wouter Wolters voted on patch set 4 CR +1 08/10/21, 14:59

  9. core-ci voted on patch set 4 V +1 08/10/21, 15:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14493

  10. Wouter Wolters voted on patch set 4 V +1 08/10/21, 17:20

  11. crell commented on patch set 4 CR +1 08/10/21, 17:35

    This is essentially a less-aggressive version of the patch I had done. I'm OK with this. One code comment that is take-it-or-leave it.

    ErrorHandler.php:150

    Stylistically I find this case better handled with an in_array(). It's generally shorter and easier to read. Not a hard-blocker, though.
  12. Benni Mack commented on patch set 4 08/10/21, 19:48

    ErrorHandler.php:150 Reply

    How about we take this to the next round once we have this one in and rebase your PR?
  13. crell commented on patch set 4 08/10/21, 21:50

    ErrorHandler.php:150 Reply

    I'm not sure if there's much left for my more-aggressive version to do after this is in, but sure, that's fine. As I said, it's more a stylistic thing than anything functional.
  14. Rudy Gnodde voted on patch set 4 CR +1 08/13/21, 12:32

  15. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/14/21, 09:34

  16. Christian Kuhn voted on patch set 4 V +2 CR +2 08/14/21, 10:41

  17. Christian Kuhn merged patch set 5 08/14/21, 10:41