Review main Merged

70292[TASK] Improve PHPunit used assertions

Wouter Wolters CR +2 V +2 Hard +295 −391 updated 08/13/21, 09:53

Commit message

Main changes are:

* Use assertArrayHasKey/assertArrayNotHasKey instead of array_key_exists.
* Fix misordered assertEquals/assertNotEquals arguments.
* Use assertCount instead of assertEquals and count() method.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 90

Show 70 more files