70293[BUGFIX] make subqueries in foreign_table_where work again
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1014
-
Lukas Niestroj uploaded patch set 1 08/09/21, 07:34
-
core-ci voted on patch set 1 V +1 08/09/21, 07:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14298
-
Benni Mack commented on patch set 1 08/09/21, 09:02
Can we have tests for these changes please? -
Christian Kuhn commented on patch set 1 08/09/21, 09:03
Not sure. foreign_table_where is ugly in the first place - having sql fragments in TCA / typoscript in general is. If we allow magic like sub queries, migrating away from this later will be even harder. Such cases sound as if they maybe could be better solved with hooks, even though i'm not sure which ones without looking at it. But there was a recent patch from helmut regarding quoting of these tca settings that moved it to where the queries are created. This could be a good starter for looking for appropriate hooks. -
Lukas Niestroj commented on patch set 1 08/09/21, 11:48
Reply
Of Course! I am working on it.Reply
Agree! I would rather have a provider or event to customize the query. I will look through the recent changes. -
Lukas Niestroj rebased onto patch set 2 08/19/21, 04:17
-
core-ci voted on patch set 2 V +1 08/19/21, 04:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15295
-
Lukas Niestroj uploaded patch set 3 08/19/21, 05:08
-
Lukas Niestroj commented on patch set 3 08/19/21, 05:09
I added a simple test case. -
core-ci voted on patch set 3 V +1 08/19/21, 05:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15296
-
Benni Mack updated the commit message in patch set 4 10/08/21, 08:23
-
core-ci voted on patch set 4 V +1 10/08/21, 08:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17801
-
Christian Kuhn commented on patch set 4 11/04/21, 14:07
Hey. I hope it's ok to abandon this one: Supporting sub selects in TCA foreign_table_where really is an edge case and probably shouldn't be supported as such - When complex data structures need to be analyzed to prepare select items, a dedicated data provider in formengine is a much better choice and gives full freedom. Typo3 explained docs have some info on this. As always, we can rediscuss this topic if needed and could resurrect the patch if new things pop up. -
Christian Kuhn abandoned the change 11/04/21, 14:08