Review main Abandoned

70312[WIP][TASK] Migrate towards webpack

Jochen Roth CR 0 V 0 Expert +2032 −91 updated 07/06/23, 11:35

Commit message

Compiles SCSS and TS using webpack.

yarn add \
    webpack webpack-cli \
    glob @sdinteractive/requirejs-export-plugin \
    ts-node  tsconfig-paths-webpack-plugin \
    ts-loader style-loader script-loader sass-loader postcss-loader \
    ignore-loader file-loader extract-loader css-loader babel-loader \
    awesome-typescript-loader \
    @types/webpack @types/node

Review

  • Code review CR 0
  • Verified V 0

Files 52

Show 32 more files

Review log 1114

  1. Jochen Roth uploaded patch set 1 08/09/21, 16:40

  2. Mathias Brodala commented on patch set 1 08/09/21, 16:42

    I know this is early WIP (you can officially mark changes as WIP in Gerrit BTW) but have you considered Symfony Encore as abstraction on top of Webpack? This could make the Webpack configuration easier to read. See https://symfony.com/doc/current/frontend/encore/installation.html#installing-encore-in-non-symfony-applications And https://symfony.com/doc/current/frontend/encore/installation.html#creating-the-webpack-config-js-file
  3. Jochen Roth marked it work in progress 08/09/21, 16:48

  4. Jochen Roth commented on patch set 1 08/09/21, 16:48

    Reply

    I'll have a look, thanks :-)
  5. core-ci voted on patch set 1 V -1 08/09/21, 17:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14347

  6. Benni Mack wrote 11/29/21, 10:10

    Change destination moved from master to main
  7. Benni Mack updated the commit message in patch set 2 11/29/21, 11:56

  8. core-ci voted on patch set 2 V -1 11/29/21, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19976

  9. Benjamin Franzke commented on patch set 2 12/08/21, 21:46

    PageBrowser.ts:15

    Hey Jochen, what was the reason to import from the separate modules instead of the umbrella module 'lit/decorators'? Was there any technical limitation to keep using 'lit/decorators'?
  10. Benjamin Franzke uploaded patch set 3 12/08/21, 22:14

    Rebase
  11. Benjamin Franzke commented on patch set 3 12/08/21, 22:18

    webpack.config.js:33

    Is there a possibility to to only emit the module of the entry file, not a bundle containing all the dependencies of each module? (maybe via a loader?) (someting like preserveModules for rollup)
  12. core-ci voted on patch set 3 V -1 12/08/21, 22:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20823

  13. Jochen Roth commented on patch set 3 12/09/21, 09:56

    PageBrowser.ts:15 Reply Unresolved

    Hey Benjamin, iirc webpack had issues importing it. If 'lit/decorators' works as well now i'm happy to use that. :-)

    webpack.config.js:33 Reply Unresolved

    Yes, this is my issue. Currently each file is bundled with all it's dependencies which then causes things to break. Well, it's possible to split the modules but that seemed to cause a lot of issues especially with requireJS. preserveModules for rollup sounds interesting, will look that up if i have the time.
  14. Jochen Roth abandoned the change 07/06/23, 11:35

    Not going happen