Review main Merged

7033[BUGFIX] Unset stdWrap of select.pidInList

Marc Bastian Heinrichs CR +2 V +2 Easy +3 −0 updated 06/03/13, 20:49

Commit message

Using stdWrap features on select.pidInList together with slide will
result in an endless loop because the same parentPids are
selected over and over again till the max execution time is reached.

This patch unsets the stdWrap properties after the first run.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1

Files 1

Review log 11

  1. Tolleiv Nietsch commented on patch set 1 02/09/12, 22:13

    Seems valid - how can the be tested/reproduced?
  2. Tolleiv Nietsch commented on patch set 2 02/09/12, 22:13

    Verified; Looks good to me, but someone else must approve
  3. Tolleiv Nietsch commented on patch set 2 V 0 02/09/12, 22:13

    by team member; Looks good to me, approved
  4. Markus Klein uploaded patch set 2 02/09/12, 22:13

  5. Markus Klein commented on patch set 2 02/09/12, 22:13

    Looks good to me, but someone else must approve Just a small fix of the commit message and added Topic
  6. Marc Bastian Heinrichs commented on patch set 1 02/09/12, 22:13

    have a look in the forge issue
  7. Philipp Gampe commented on patch set 2 02/09/12, 22:13

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 02/09/12, 22:13

  9. Mr. Jenkins commented on patch set 2 02/09/12, 22:13

  10. Wouter Wolters commented on patch set 2 02/09/12, 22:13

    Looks good to me, but someone else must approve
  11. Tolleiv Nietsch merged patch set 2 02/09/12, 22:13