70401[TASK] Show more details in "delete" confirmation modal
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 37
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine.ts2+10 −8
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php2+19 −2
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+12 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+8 −3
- typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf+68 −3
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+1 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration_tca.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html2+8 −4
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php2+1 −0
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+5 −3
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedList.html+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Recycler/RecyclerModuleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+1 −1
Show 17 more files
- typo3/sysext/core/Tests/Acceptance/Application/Site/SiteModuleCest.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php2+4 −2
- typo3/sysext/filelist/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+11 −0
- typo3/sysext/form/Resources/Private/Language/locallang_formManager_javascript.xlf+5 −5
- typo3/sysext/form/Resources/Private/Templates/Backend/FormManager/Index.html+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js2+1 −1
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php1+24 −0
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_form.xlf1+2 −2
- typo3/sysext/recycler/Resources/Private/Language/locallang.xlf+2 −2
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+7 −0
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+5 −3
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+20 −5
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+7 −1
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+3 −1
- typo3/sysext/sys_note/Classes/Renderer/NoteRenderer.php+18 −0
- typo3/sysext/sys_note/Resources/Private/Templates/List.html+3 −2
Review log 87133
Show 69108 earlier messages
-
Jochen Roth uploaded patch set 1 08/10/21, 14:15
-
core-ci voted on patch set 1 V +1 08/10/21, 14:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14490
-
Oli Bartsch commented on patch set 1 V -1 08/10/21, 15:46
Thanks for bringing back a more precise message to this modal. However, there are still some differences between the content of this modal and other modals for the same "process", e.g. called from recordlist. The message in recordlist is as following: > Are you sure you want to delete this record? “Some placeholder” [tt_content:204] We might want to be consistent here, what do you think? Also the CType information might not be relevant for editors, unless it's the resolved items label. Furthermore does the current state not respect relations. If you try to delete a content element with relations following info is displayed in recordlist: > Are you sure you want to delete this record? "Some placeholder” [tt_content:204] (There are 1 > reference(s) to this record!) This information is actually really interesting and should IMO not be omitted. Especially because it was also displayed in the former PageLayoutView implementation. -
Jochen Roth uploaded patch set 2 08/11/21, 14:27
-
Jochen Roth updated the commit message in patch set 3 08/11/21, 14:29
-
core-ci voted on patch set 2 V -1 08/11/21, 14:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14603
-
core-ci voted on patch set 3 V -1 08/11/21, 14:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14604
-
Jochen Roth uploaded patch set 4 08/11/21, 19:39
-
core-ci voted on patch set 4 V -1 08/11/21, 19:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14630
-
Jochen Roth uploaded patch set 5 08/12/21, 08:30
-
core-ci voted on patch set 5 V -1 08/12/21, 08:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14658
-
Jochen Roth uploaded patch set 6 08/12/21, 08:47
-
core-ci voted on patch set 6 V -1 08/12/21, 09:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14659
-
Jochen Roth uploaded patch set 7 08/12/21, 12:08
-
core-ci voted on patch set 7 V +1 08/12/21, 12:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14716
-
Björn Jacob commented on patch set 7 CR -1 08/13/21, 15:24
Let's wait till https://review.typo3.org/c/Packages/TYPO3.CMS/+/70450 is merged. -
Björn Jacob commented on patch set 7 CR 0 08/13/21, 15:35
Merged now. -
Jochen Roth uploaded patch set 8 08/14/21, 16:11
-
core-ci voted on patch set 8 V +1 08/14/21, 16:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15097
-
Benni Mack voted on patch set 8 V +1 CR +1 08/24/21, 14:52
-
Christian Kuhn commented on patch set 8 08/25/21, 16:08
GridColumnItem.php:142LF instead of PHP_EOL, please. But more importantly: htmlspecialchars() needed here?! -
Jochen Roth uploaded patch set 9 08/26/21, 09:10
-
core-ci voted on patch set 9 V +1 08/26/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15659
-
Jochen Roth commented on patch set 9 08/26/21, 13:04
GridColumnItem.php:142ReplyDone -
Benni Mack commented on patch set 9 V +1 CR +1 08/27/21, 10:14
Will become more interesting again once we use the "Multi-Selection Delete" modal (which currently use in FileList). I think we would need to revisit this change to show a deletion process for files which have references. -
Jochen Roth uploaded patch set 10 09/03/21, 18:50
-
core-ci voted on patch set 10 V -1 09/03/21, 19:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16212
-
Jochen Roth uploaded patch set 11 09/03/21, 21:29
-
core-ci voted on patch set 11 V -1 09/03/21, 21:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16218
-
Jochen Roth uploaded patch set 12 09/06/21, 09:47
-
core-ci voted on patch set 12 V -1 09/06/21, 10:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16315
-
Jochen Roth uploaded patch set 13 09/06/21, 11:16
-
core-ci voted on patch set 13 V +1 09/06/21, 11:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16316
-
Jochen Roth uploaded patch set 14 09/06/21, 13:40
-
core-ci voted on patch set 14 V +1 09/06/21, 13:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16325
-
Jochen Roth uploaded patch set 15 09/17/21, 09:25
-
Jochen Roth uploaded patch set 16 09/17/21, 09:28
-
core-ci voted on patch set 15 V +1 09/17/21, 09:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16861
-
Jochen Roth uploaded patch set 17 09/17/21, 09:42
-
core-ci voted on patch set 16 V +1 09/17/21, 09:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16862
-
core-ci voted on patch set 17 V +1 09/17/21, 09:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16863
-
Benni Mack uploaded patch set 18 09/21/21, 11:29
-
core-ci voted on patch set 18 V +1 09/21/21, 11:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16982
-
Oli Bartsch commented on patch set 18 CR -1 09/21/21, 13:27
On it -
Oli Bartsch commented on patch set 18 09/21/21, 14:12
Reply
A lot of labels were changed to include placeholders. However usages of those labels wasn't adjusted. For example in scheduler edit view or in FormEngine. This now leads to messages like: "Are you sure you want to delete this record '%s'?". Could you therefore please check all those changed labels for their usages? -
Benni Mack wrote 10/01/21, 13:31
Removed reviewer Benni Mack. -
Jochen Roth uploaded patch set 19 10/18/21, 16:10
-
core-ci voted on patch set 19 V +1 10/18/21, 16:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18284
-
Jochen Roth uploaded patch set 20 10/27/21, 20:46
-
core-ci voted on patch set 20 V +1 10/27/21, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18633
-
Jochen Roth uploaded patch set 21 10/29/21, 13:28
-
Jochen Roth commented on patch set 21 10/29/21, 13:30
Depends on this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001 -
core-ci voted on patch set 21 V -1 10/29/21, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18654
-
Jochen Roth uploaded patch set 22 10/29/21, 14:39
-
Jochen Roth commented on patch set 21 10/29/21, 14:40
Reply
Once this is merged the tests should turn green. -
Jochen Roth uploaded patch set 23 10/29/21, 14:45
-
core-ci voted on patch set 22 V -1 10/29/21, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18656
-
core-ci voted on patch set 23 V -1 10/29/21, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18657
-
Benni Mack wrote 11/29/21, 10:11
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 24 11/29/21, 11:56
-
core-ci voted on patch set 24 V -1 11/29/21, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19978
-
Jochen Roth uploaded patch set 25 12/13/21, 14:01
-
Jochen Roth commented on patch set 25 12/13/21, 14:03
Changed "... delete this record '%s'" to "... delete the record '%s'", see suggestion here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001/10..12/typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf#b133 -
core-ci voted on patch set 25 V -1 12/13/21, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21032
-
Jochen Roth uploaded patch set 26 01/10/22, 12:23
-
core-ci voted on patch set 26 V -1 01/10/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21848
-
Jochen Roth uploaded patch set 27 07/12/22, 13:01
-
Jochen Roth marked it work in progress 07/12/22, 13:07
-
core-ci voted on patch set 27 V -1 07/12/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28974
-
Jochen Roth uploaded patch set 28 07/12/22, 16:34
-
core-ci voted on patch set 28 V -1 07/12/22, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28992
-
Jochen Roth uploaded patch set 29 07/12/22, 16:51
-
core-ci voted on patch set 29 V +1 07/12/22, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28995
-
Jochen Roth uploaded patch set 30 07/12/22, 17:38
-
Jochen Roth uploaded patch set 31 07/12/22, 17:40
-
core-ci voted on patch set 31 V +1 07/12/22, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29005
-
core-ci voted on patch set 30 V +1 07/12/22, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29004
-
Jochen Roth marked it ready for review 07/12/22, 18:59
-
Andreas Kienast commented on patch set 31 07/13/22, 06:50
General remark: I think the modal headers could be specified based on their usage (e.g. "Delete redirect" or "Delete scheduler task", could be fetched from TCA's ctrl/title in some cases). See my remark in typo3/sysext/filelist/Classes/FileList.php for example.FileList.php:1084This renders "Delete this record?" for files and folders which is kinda confusing. -
Jochen Roth uploaded patch set 32 07/13/22, 11:26
-
Jochen Roth commented on patch set 32 07/13/22, 11:32
Reply
Tried to be more explicit.FileList.php:1084ReplyDone -
core-ci voted on patch set 32 V -1 07/13/22, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29058
-
Jochen Roth uploaded patch set 33 07/13/22, 13:51
-
core-ci voted on patch set 33 V +1 07/13/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29064
-
Andreas Kienast updated the commit message in patch set 34 07/13/22, 14:01
-
core-ci voted on patch set 34 V +1 07/13/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29065
-
Andreas Kienast voted on patch set 34 V +1 07/13/22, 14:13
-
Anja Leichsenring voted on patch set 34 V +1 CR +1 07/13/22, 15:41
-
Andreas Kienast commented on patch set 34 V -1 07/15/22, 06:47
Deleting a record in EditDocumentController says: Delete this record? [tt_content:1] -
Andreas Kienast uploaded patch set 35 07/15/22, 07:02
-
Andreas Kienast voted on patch set 35 V +1 CR +1 07/15/22, 07:03
-
Andreas Kienast uploaded patch set 36 07/15/22, 07:05
-
Andreas Kienast voted on patch set 36 V +1 CR +1 07/15/22, 07:06
-
core-ci voted on patch set 35 V +1 07/15/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29186
-
core-ci voted on patch set 36 V +1 07/15/22, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29187
-
Jochen Roth voted on patch set 36 V +1 CR +1 07/15/22, 07:22
-
Oli Bartsch commented on patch set 36 CR -1 07/15/22, 07:31
reviewing -
Oli Bartsch commented on patch set 36 07/15/22, 08:29
Reply
Has this been done at all places?form-engine.ts:1136Should we do those adjustments in inline-control-container.ts and site-language-container.ts as well?EditDocumentController.php:1553This has to be added in the sprintf() call, too.Overview.html:138Should we also add the debug message here? We could use the pseudo "site" record and the rootPageId, so something like "Are you sure you want to delete the site 'my-site-identifier [site:123]'".BackendUserController.php:165I think this type cast is superfluous.view-model.js:541Should we also add some kind of debug info here (e.g. the location as unique identifier)? -
Jochen Roth uploaded patch set 37 07/16/22, 00:22
-
Jochen Roth commented on patch set 37 07/16/22, 00:22
form-engine.ts:1136ReplyDoneEditDocumentController.php:1553ReplyDoneOverview.html:138ReplyDone - added to the unassigned sites as well.BackendUserController.php:165ReplyAckview-model.js:541ReplyDone -
Jochen Roth commented on patch set 37 07/16/22, 00:24
still on it -
Jochen Roth commented on patch set 37 07/16/22, 00:25
Reply
Done -
core-ci voted on patch set 37 V -1 07/16/22, 00:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29250
-
Jochen Roth uploaded patch set 38 07/16/22, 16:09
-
core-ci voted on patch set 38 V -1 07/16/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29287
-
Jochen Roth uploaded patch set 39 07/16/22, 17:13
-
Jochen Roth uploaded patch set 40 07/16/22, 17:22
-
core-ci voted on patch set 39 V -1 07/16/22, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29288
-
Jochen Roth uploaded patch set 41 07/16/22, 17:26
-
core-ci voted on patch set 40 V -1 07/16/22, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29290
-
core-ci voted on patch set 41 V -1 07/16/22, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29291
-
Jochen Roth uploaded patch set 42 07/17/22, 19:33
-
Jochen Roth commented on patch set 42 07/17/22, 19:40
FormManagerControllerTest.php:222UnresolvedNot sure if that makes any sense. -
core-ci voted on patch set 42 V -1 07/17/22, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29318
-
Jochen Roth commented on patch set 43 07/17/22, 22:19
Published edit on patch set 42. -
core-ci voted on patch set 43 V -1 07/17/22, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29320
-
Jochen Roth uploaded patch set 44 07/17/22, 22:54
-
core-ci voted on patch set 44 V +1 07/17/22, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29322
-
Jochen Roth commented on patch set 44 07/17/22, 23:08
Reply
Looks good to me now. -
Anja Leichsenring voted on patch set 44 V +1 CR +1 07/18/22, 13:07
-
Anja Leichsenring uploaded patch set 45 08/02/22, 08:37
-
Anja Leichsenring voted on patch set 45 V +1 CR +1 08/02/22, 08:38
-
core-ci voted on patch set 45 V -1 08/02/22, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29775
-
Anja Leichsenring uploaded patch set 46 08/02/22, 10:12
-
Anja Leichsenring voted on patch set 46 V +1 CR +1 08/02/22, 10:12
-
core-ci voted on patch set 46 V +1 08/02/22, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29779
-
Simon Schaufelberger commented on patch set 46 08/03/22, 22:50
locallang_form.xlf:5Unresolvedis this on purpose? -
Benni Mack commented on patch set 46 07/04/23, 13:17
ping. what is the status here? -
Simon Schaufelberger commented on patch set 46 08/14/23, 05:28
Would someone please rebase this one? -
Andreas Kienast commented on patch set 46 08/14/23, 07:29
Reply
We need another approach here before continuing with this patch. -
Anja Leichsenring wrote 07/31/24, 18:15
Removed reviewer Anja Leichsenring with the following votes: * Verified+1 by Anja Leichsenring * Code-Review+1 by Anja Leichsenring -
Benni Mack marked it work in progress 04/11/25, 10:09
-
Benni Mack abandoned the change 04/11/25, 10:09
abandoning here, seems like this has been stalled for too long