Review main Abandoned

70401[TASK] Show more details in "delete" confirmation modal

Jochen Roth CR 0 V 0 Hard +265 −61 updated 04/11/25, 10:09

Commit message

Currently, the delete modal does not show
which record is going to be deleted.

Added header, table, uid, and references to the modal
so it's clear which record will be deleted.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 37

Show 17 more files

Review log 87133

Show 69108 earlier messages
  1. Jochen Roth uploaded patch set 1 08/10/21, 14:15

  2. core-ci voted on patch set 1 V +1 08/10/21, 14:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14490

  3. Oli Bartsch commented on patch set 1 V -1 08/10/21, 15:46

    Thanks for bringing back a more precise message to this modal. However, there are still some differences between the content of this modal and other modals for the same "process", e.g. called from recordlist. The message in recordlist is as following: > Are you sure you want to delete this record? “Some placeholder” [tt_content:204] We might want to be consistent here, what do you think? Also the CType information might not be relevant for editors, unless it's the resolved items label. Furthermore does the current state not respect relations. If you try to delete a content element with relations following info is displayed in recordlist: > Are you sure you want to delete this record? "Some placeholder” [tt_content:204] (There are 1 > reference(s) to this record!) This information is actually really interesting and should IMO not be omitted. Especially because it was also displayed in the former PageLayoutView implementation.
  4. Jochen Roth uploaded patch set 2 08/11/21, 14:27

  5. Jochen Roth updated the commit message in patch set 3 08/11/21, 14:29

  6. core-ci voted on patch set 2 V -1 08/11/21, 14:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14603

  7. core-ci voted on patch set 3 V -1 08/11/21, 14:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14604

  8. Jochen Roth uploaded patch set 4 08/11/21, 19:39

  9. core-ci voted on patch set 4 V -1 08/11/21, 19:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14630

  10. Jochen Roth uploaded patch set 5 08/12/21, 08:30

  11. core-ci voted on patch set 5 V -1 08/12/21, 08:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14658

  12. Jochen Roth uploaded patch set 6 08/12/21, 08:47

  13. core-ci voted on patch set 6 V -1 08/12/21, 09:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14659

  14. Jochen Roth uploaded patch set 7 08/12/21, 12:08

  15. core-ci voted on patch set 7 V +1 08/12/21, 12:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14716

  16. Björn Jacob commented on patch set 7 CR -1 08/13/21, 15:24

  17. Björn Jacob commented on patch set 7 CR 0 08/13/21, 15:35

    Merged now.
  18. Jochen Roth uploaded patch set 8 08/14/21, 16:11

  19. core-ci voted on patch set 8 V +1 08/14/21, 16:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15097

  20. Benni Mack voted on patch set 8 V +1 CR +1 08/24/21, 14:52

  21. Christian Kuhn commented on patch set 8 08/25/21, 16:08

    GridColumnItem.php:142

    LF instead of PHP_EOL, please. But more importantly: htmlspecialchars() needed here?!
  22. Jochen Roth uploaded patch set 9 08/26/21, 09:10

  23. core-ci voted on patch set 9 V +1 08/26/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15659

  24. Jochen Roth commented on patch set 9 08/26/21, 13:04

    GridColumnItem.php:142 Reply

    Done
  25. Benni Mack commented on patch set 9 V +1 CR +1 08/27/21, 10:14

    Will become more interesting again once we use the "Multi-Selection Delete" modal (which currently use in FileList). I think we would need to revisit this change to show a deletion process for files which have references.
  26. Jochen Roth uploaded patch set 10 09/03/21, 18:50

  27. core-ci voted on patch set 10 V -1 09/03/21, 19:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16212

  28. Jochen Roth uploaded patch set 11 09/03/21, 21:29

  29. core-ci voted on patch set 11 V -1 09/03/21, 21:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16218

  30. Jochen Roth uploaded patch set 12 09/06/21, 09:47

  31. core-ci voted on patch set 12 V -1 09/06/21, 10:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16315

  32. Jochen Roth uploaded patch set 13 09/06/21, 11:16

  33. core-ci voted on patch set 13 V +1 09/06/21, 11:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16316

  34. Jochen Roth uploaded patch set 14 09/06/21, 13:40

  35. core-ci voted on patch set 14 V +1 09/06/21, 13:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16325

  36. Jochen Roth uploaded patch set 15 09/17/21, 09:25

  37. Jochen Roth uploaded patch set 16 09/17/21, 09:28

  38. core-ci voted on patch set 15 V +1 09/17/21, 09:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16861

  39. Jochen Roth uploaded patch set 17 09/17/21, 09:42

  40. core-ci voted on patch set 16 V +1 09/17/21, 09:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16862

  41. core-ci voted on patch set 17 V +1 09/17/21, 09:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16863

  42. Benni Mack uploaded patch set 18 09/21/21, 11:29

  43. core-ci voted on patch set 18 V +1 09/21/21, 11:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16982

  44. Oli Bartsch commented on patch set 18 CR -1 09/21/21, 13:27

    On it
  45. Oli Bartsch commented on patch set 18 09/21/21, 14:12

    Reply

    A lot of labels were changed to include placeholders. However usages of those labels wasn't adjusted. For example in scheduler edit view or in FormEngine. This now leads to messages like: "Are you sure you want to delete this record '%s'?". Could you therefore please check all those changed labels for their usages?
  46. Benni Mack wrote 10/01/21, 13:31

    Removed reviewer Benni Mack.
  47. Jochen Roth uploaded patch set 19 10/18/21, 16:10

  48. core-ci voted on patch set 19 V +1 10/18/21, 16:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18284

  49. Jochen Roth uploaded patch set 20 10/27/21, 20:46

  50. core-ci voted on patch set 20 V +1 10/27/21, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18633

  51. Jochen Roth uploaded patch set 21 10/29/21, 13:28

  52. Jochen Roth commented on patch set 21 10/29/21, 13:30

  53. core-ci voted on patch set 21 V -1 10/29/21, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18654

  54. Jochen Roth uploaded patch set 22 10/29/21, 14:39

  55. Jochen Roth commented on patch set 21 10/29/21, 14:40

    Reply

    Once this is merged the tests should turn green.
  56. Jochen Roth uploaded patch set 23 10/29/21, 14:45

  57. core-ci voted on patch set 22 V -1 10/29/21, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18656

  58. core-ci voted on patch set 23 V -1 10/29/21, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18657

  59. Benni Mack wrote 11/29/21, 10:11

    Change destination moved from master to main
  60. Benni Mack updated the commit message in patch set 24 11/29/21, 11:56

  61. core-ci voted on patch set 24 V -1 11/29/21, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19978

  62. Jochen Roth uploaded patch set 25 12/13/21, 14:01

  63. Jochen Roth commented on patch set 25 12/13/21, 14:03

    Changed "... delete this record '%s'" to "... delete the record '%s'", see suggestion here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001/10..12/typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf#b133
  64. core-ci voted on patch set 25 V -1 12/13/21, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21032

  65. Jochen Roth uploaded patch set 26 01/10/22, 12:23

  66. core-ci voted on patch set 26 V -1 01/10/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21848

  67. Jochen Roth uploaded patch set 27 07/12/22, 13:01

  68. Jochen Roth marked it work in progress 07/12/22, 13:07

  69. core-ci voted on patch set 27 V -1 07/12/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28974

  70. Jochen Roth uploaded patch set 28 07/12/22, 16:34

  71. core-ci voted on patch set 28 V -1 07/12/22, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28992

  72. Jochen Roth uploaded patch set 29 07/12/22, 16:51

  73. core-ci voted on patch set 29 V +1 07/12/22, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28995

  74. Jochen Roth uploaded patch set 30 07/12/22, 17:38

  75. Jochen Roth uploaded patch set 31 07/12/22, 17:40

  76. core-ci voted on patch set 31 V +1 07/12/22, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29005

  77. core-ci voted on patch set 30 V +1 07/12/22, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29004

  78. Jochen Roth marked it ready for review 07/12/22, 18:59

  79. Andreas Kienast commented on patch set 31 07/13/22, 06:50

    General remark: I think the modal headers could be specified based on their usage (e.g. "Delete redirect" or "Delete scheduler task", could be fetched from TCA's ctrl/title in some cases). See my remark in typo3/sysext/filelist/Classes/FileList.php for example.

    FileList.php:1084

    This renders "Delete this record?" for files and folders which is kinda confusing.
  80. Jochen Roth uploaded patch set 32 07/13/22, 11:26

  81. Jochen Roth commented on patch set 32 07/13/22, 11:32

    Reply

    Tried to be more explicit.

    FileList.php:1084 Reply

    Done
  82. core-ci voted on patch set 32 V -1 07/13/22, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29058

  83. Jochen Roth uploaded patch set 33 07/13/22, 13:51

  84. core-ci voted on patch set 33 V +1 07/13/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29064

  85. Andreas Kienast updated the commit message in patch set 34 07/13/22, 14:01

  86. core-ci voted on patch set 34 V +1 07/13/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29065

  87. Andreas Kienast voted on patch set 34 V +1 07/13/22, 14:13

  88. Anja Leichsenring voted on patch set 34 V +1 CR +1 07/13/22, 15:41

  89. Andreas Kienast commented on patch set 34 V -1 07/15/22, 06:47

    Deleting a record in EditDocumentController says: Delete this record? [tt_content:1]
  90. Andreas Kienast uploaded patch set 35 07/15/22, 07:02

  91. Andreas Kienast voted on patch set 35 V +1 CR +1 07/15/22, 07:03

  92. Andreas Kienast uploaded patch set 36 07/15/22, 07:05

  93. Andreas Kienast voted on patch set 36 V +1 CR +1 07/15/22, 07:06

  94. core-ci voted on patch set 35 V +1 07/15/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29186

  95. core-ci voted on patch set 36 V +1 07/15/22, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29187

  96. Jochen Roth voted on patch set 36 V +1 CR +1 07/15/22, 07:22

  97. Oli Bartsch commented on patch set 36 CR -1 07/15/22, 07:31

    reviewing
  98. Oli Bartsch commented on patch set 36 07/15/22, 08:29

    Reply

    Has this been done at all places?

    form-engine.ts:1136

    Should we do those adjustments in inline-control-container.ts and site-language-container.ts as well?

    EditDocumentController.php:1553

    This has to be added in the sprintf() call, too.

    Overview.html:138

    Should we also add the debug message here? We could use the pseudo "site" record and the rootPageId, so something like "Are you sure you want to delete the site 'my-site-identifier [site:123]'".

    BackendUserController.php:165

    I think this type cast is superfluous.

    view-model.js:541

    Should we also add some kind of debug info here (e.g. the location as unique identifier)?
  99. Jochen Roth uploaded patch set 37 07/16/22, 00:22

  100. Jochen Roth commented on patch set 37 07/16/22, 00:22

    form-engine.ts:1136 Reply

    Done

    EditDocumentController.php:1553 Reply

    Done

    Overview.html:138 Reply

    Done - added to the unassigned sites as well.

    BackendUserController.php:165 Reply

    Ack

    view-model.js:541 Reply

    Done
  101. Jochen Roth commented on patch set 37 07/16/22, 00:24

    still on it
  102. Jochen Roth commented on patch set 37 07/16/22, 00:25

    Reply

    Done
  103. core-ci voted on patch set 37 V -1 07/16/22, 00:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29250

  104. Jochen Roth uploaded patch set 38 07/16/22, 16:09

  105. core-ci voted on patch set 38 V -1 07/16/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29287

  106. Jochen Roth uploaded patch set 39 07/16/22, 17:13

  107. Jochen Roth uploaded patch set 40 07/16/22, 17:22

  108. core-ci voted on patch set 39 V -1 07/16/22, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29288

  1. Jochen Roth uploaded patch set 41 07/16/22, 17:26

  2. core-ci voted on patch set 40 V -1 07/16/22, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29290

  3. core-ci voted on patch set 41 V -1 07/16/22, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29291

  4. Jochen Roth uploaded patch set 42 07/17/22, 19:33

  5. Jochen Roth commented on patch set 42 07/17/22, 19:40

    FormManagerControllerTest.php:222 Unresolved

    Not sure if that makes any sense.
  6. core-ci voted on patch set 42 V -1 07/17/22, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29318

  7. Jochen Roth commented on patch set 43 07/17/22, 22:19

    Published edit on patch set 42.
  8. core-ci voted on patch set 43 V -1 07/17/22, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29320

  9. Jochen Roth uploaded patch set 44 07/17/22, 22:54

  10. core-ci voted on patch set 44 V +1 07/17/22, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29322

  11. Jochen Roth commented on patch set 44 07/17/22, 23:08

    Reply

    Looks good to me now.
  12. Anja Leichsenring voted on patch set 44 V +1 CR +1 07/18/22, 13:07

  13. Anja Leichsenring uploaded patch set 45 08/02/22, 08:37

  14. Anja Leichsenring voted on patch set 45 V +1 CR +1 08/02/22, 08:38

  15. core-ci voted on patch set 45 V -1 08/02/22, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29775

  16. Anja Leichsenring uploaded patch set 46 08/02/22, 10:12

  17. Anja Leichsenring voted on patch set 46 V +1 CR +1 08/02/22, 10:12

  18. core-ci voted on patch set 46 V +1 08/02/22, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29779

  19. Simon Schaufelberger commented on patch set 46 08/03/22, 22:50

    locallang_form.xlf:5 Unresolved

    is this on purpose?
  20. Benni Mack commented on patch set 46 07/04/23, 13:17

    ping. what is the status here?
  21. Simon Schaufelberger commented on patch set 46 08/14/23, 05:28

    Would someone please rebase this one?
  22. Andreas Kienast commented on patch set 46 08/14/23, 07:29

    Reply

    We need another approach here before continuing with this patch.
  23. Anja Leichsenring wrote 07/31/24, 18:15

    Removed reviewer Anja Leichsenring with the following votes: * Verified+1 by Anja Leichsenring * Code-Review+1 by Anja Leichsenring
  24. Benni Mack marked it work in progress 04/11/25, 10:09

  25. Benni Mack abandoned the change 04/11/25, 10:09

    abandoning here, seems like this has been stalled for too long