Review main Merged

70402[BUGFIX] Fix undefined array key in XmlSitemapRenderer

Jochen Roth CR +2 V +2 Easy +2 −2 updated 08/11/21, 11:34

Commit message

When calling the sitemap (type 1533906435) undefined
key warnings are thrown.

This is fixed by properly checking the array key.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Jochen Roth uploaded patch set 1 08/10/21, 15:36

  2. core-ci voted on patch set 1 V +1 08/10/21, 15:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14494

  3. Oli Bartsch commented on patch set 1 CR -1 08/10/21, 15:50

    XmlSitemapRenderer.php:138 Unresolved

    This is a change in behaviour. This could led to $template being an empty string.
  4. Jochen Roth uploaded patch set 2 08/11/21, 09:58

  5. core-ci voted on patch set 2 V +1 08/11/21, 10:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14569

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 08/11/21, 10:14

  7. Georg Ringer voted on patch set 2 V +2 CR +2 08/11/21, 11:34

  8. Georg Ringer merged patch set 3 08/11/21, 11:34