Review main Merged

70408[BUGFIX] Fix misuse of in_array function in RequestBuilder of Extbase

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 08/12/21, 12:06

Commit message

The function array_key_exists should be used instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • crell +1
    • Roman Büchler +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Roman Büchler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Wouter Wolters uploaded patch set 1 08/10/21, 17:19

  2. core-ci voted on patch set 1 V +1 08/10/21, 17:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14504

  3. crell voted on patch set 1 CR +1 08/10/21, 19:40

  4. Roman Büchler voted on patch set 1 V +1 CR +1 08/12/21, 11:45

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 08/12/21, 12:06

  6. Christian Kuhn merged patch set 2 08/12/21, 12:06