Review main Merged

7042[BUGFIX] INTincScript_loadJSCode() causes PHP warnings

Markus Klein CR +2 V +2 Easy +16 −9 updated 06/03/13, 20:49

Commit message

This function uses implode() on several variables without properly
checking if they are actually arrays.
This might cause PHP warnings.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
  • Verified V +2
    • Dmitry Dulepov +2

Files 1

Review log 55

Show 30 earlier messages
  1. Stefan Neufeind commented on patch set 2 12/06/12, 10:07

    (1 inline comment) looks fine for me (just a nitpick with tab/space). Thanks also for the cleanup done.

    class.tslib_fe.php:3266

    space instead of tab
  2. Stefan Neufeind commented on patch set 2 12/06/12, 10:07

    (1 inline comment)
  3. Stefan Neufeind uploaded patch set 3 12/06/12, 10:07

  4. Stefan Neufeind uploaded patch set 4 12/06/12, 10:07

  5. Stefan Neufeind commented on patch set 4 12/06/12, 10:07

    Looks good to me, but someone else must approve rolled in suggested changes, fixed submodule-pointers
  6. Markus Klein uploaded patch set 2 12/06/12, 10:07

  7. Markus Klein commented on patch set 4 1 comment 12/06/12, 10:07

    I would prefer that you didn't submit this
  8. Stefan Neufeind commented on patch set 5 12/06/12, 10:07

    Looks good to me, but someone else must approve
  9. Markus Klein commented on patch set 5 12/06/12, 10:07

    (1 inline comment)
  10. Markus Klein uploaded patch set 5 12/06/12, 10:07

  11. Stefan Neufeind commented on patch set 6 12/06/12, 10:07

    Looks good to me, but someone else must approve
  12. Markus Klein commented on patch set 6 1 comment 12/06/12, 10:07

    No score
  13. Markus Klein uploaded patch set 6 12/06/12, 10:07

  14. Markus Klein commented on patch set 6 12/06/12, 10:07

    Verified; Looks good to me, but someone else must approve Voting for my own patch. Reflecting the status of patch set 5 from Xavier and Razakanirina.
  15. Markus Klein commented on patch set 7 12/06/12, 10:07

    (2 inline comments)
  16. Markus Klein uploaded patch set 7 12/06/12, 10:07

  17. Stefan Neufeind commented on patch set 8 12/06/12, 10:07

    Looks good to me, but someone else must approve
  18. Stefan Neufeind commented on patch set 8 12/06/12, 10:07

    please consider to merge
  19. Markus Klein uploaded patch set 8 12/06/12, 10:07

  20. Markus Klein commented on patch set 8 12/06/12, 10:07

    Sorry Olly, didn't see your comment before pushing Set 8.
  21. Markus Klein uploaded patch set 9 12/06/12, 10:07

  22. Dmitry Dulepov commented on patch set 10 1 comment 12/06/12, 10:07

    I would prefer that you didn't submit this Sorry to give a -1 to a useful patch but there is one moment there I did not like. Please, see my inline comment.
  23. Markus Klein uploaded patch set 10 12/06/12, 10:07

  24. Dmitry Dulepov uploaded patch set 12 12/06/12, 10:07

  25. Dmitry Dulepov commented on patch set 12 V 0 12/06/12, 10:07

    by team member; Looks good to me, approved
  26. Markus Klein uploaded patch set 11 12/06/12, 10:07

  27. Oliver Klee commented on patch set 2 12/06/12, 10:07

    Looks good to me, but someone else must approve

    class.tslib_fe.php:3237

    JSImgCode -> jsImgCode (so we have proper camelCase)

    class.tslib_fe.php:3237 Reply

    Yes, that's what I meant. Sorry for the confusion.

    class.tslib_fe.php:3251

    JSCode -> jsCode

    class.tslib_fe.php:3265

    additionalCSS -> additionalCss
  28. Oliver Klee commented on patch set 2 12/06/12, 10:07

    (3 inline comments)
  29. Oliver Klee commented on patch set 2 12/06/12, 10:07

    (1 inline comment)
  30. Oliver Klee commented on patch set 4 12/06/12, 10:07

    Looks good to me, but someone else must approve
  1. Oliver Klee commented on patch set 5 12/06/12, 10:07

    Looks good to me, but someone else must approve
  2. Oliver Klee commented on patch set 6 12/06/12, 10:07

    Looks good to me, but someone else must approve
  3. Oliver Klee commented on patch set 6 12/06/12, 10:07

    (1 inline comment)
  4. Oliver Klee commented on patch set 8 12/06/12, 10:07

    Looks good to me, but someone else must approve
  5. Oliver Hader commented on patch set 7 2 comments 12/06/12, 10:07

    Fails; I would prefer that you didn't submit this I did not follow all comments - but was is causing this issue? The mentioned members expect array, so with functionality puts regular strings there?
  6. Xavier Perseguers commented on patch set 5 12/06/12, 10:07

    Verified; Looks good to me, but someone else must approve
  7. Xavier Perseguers commented on patch set 6 12/06/12, 10:07

    (2 inline comments)
  8. Georg Ringer commented on patch set 5 12/06/12, 10:07

    Verified; Looks good to me, but someone else must approve

    class.tslib_fe.php:3261

    you can remove the access tag and set the function actually to private
  9. Sebastian Fischer commented on patch set 8 12/06/12, 10:07

    Looks good to me, but someone else must approve
  10. Razakanirina voted on patch set 2 V 0 12/06/12, 10:07

  11. Razakanirina commented on patch set 2 12/06/12, 10:07

    Looks good to me, but someone else must approve
  12. Razakanirina commented on patch set 5 12/06/12, 10:07

    Verified; Looks good to me, but someone else must approve
  13. Mr. Jenkins commented on patch set 1 12/06/12, 10:07

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2583/ : FAILURE
  14. Mr. Jenkins commented on patch set 2 12/06/12, 10:07

  15. Mr. Jenkins commented on patch set 3 12/06/12, 10:07

  16. Mr. Jenkins commented on patch set 4 12/06/12, 10:07

  17. Mr. Jenkins commented on patch set 5 12/06/12, 10:07

  18. Mr. Jenkins commented on patch set 6 12/06/12, 10:07

  19. Mr. Jenkins commented on patch set 7 12/06/12, 10:07

  20. Mr. Jenkins commented on patch set 8 12/06/12, 10:07

  21. Mr. Jenkins commented on patch set 9 12/06/12, 10:07

  22. Mr. Jenkins commented on patch set 10 12/06/12, 10:07

  23. Mr. Jenkins commented on patch set 11 12/06/12, 10:07

  24. Mr. Jenkins commented on patch set 12 12/06/12, 10:07

  25. Dmitry Dulepov merged patch set 12 12/06/12, 10:07