7042[BUGFIX] INTincScript_loadJSCode() causes PHP warnings
Commit message
Review
-
Code review CR +2
- Dmitry Dulepov +2
-
Verified V +2
- Dmitry Dulepov +2
Files 1
Review log 55
Show 30 earlier messages
-
Stefan Neufeind commented on patch set 2 12/06/12, 10:07
(1 inline comment) looks fine for me (just a nitpick with tab/space). Thanks also for the cleanup done.class.tslib_fe.php:3266space instead of tab -
Stefan Neufeind commented on patch set 2 12/06/12, 10:07
(1 inline comment) -
Stefan Neufeind uploaded patch set 3 12/06/12, 10:07
-
Stefan Neufeind uploaded patch set 4 12/06/12, 10:07
-
Stefan Neufeind commented on patch set 4 12/06/12, 10:07
Looks good to me, but someone else must approve rolled in suggested changes, fixed submodule-pointers -
Markus Klein uploaded patch set 2 12/06/12, 10:07
-
Markus Klein commented on patch set 4 1 comment 12/06/12, 10:07
I would prefer that you didn't submit this -
Stefan Neufeind commented on patch set 5 12/06/12, 10:07
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 5 12/06/12, 10:07
(1 inline comment) -
Markus Klein uploaded patch set 5 12/06/12, 10:07
-
Stefan Neufeind commented on patch set 6 12/06/12, 10:07
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 6 1 comment 12/06/12, 10:07
No score -
Markus Klein uploaded patch set 6 12/06/12, 10:07
-
Markus Klein commented on patch set 6 12/06/12, 10:07
Verified; Looks good to me, but someone else must approve Voting for my own patch. Reflecting the status of patch set 5 from Xavier and Razakanirina. -
Markus Klein commented on patch set 7 12/06/12, 10:07
(2 inline comments) -
Markus Klein uploaded patch set 7 12/06/12, 10:07
-
Stefan Neufeind commented on patch set 8 12/06/12, 10:07
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 8 12/06/12, 10:07
please consider to merge -
Markus Klein uploaded patch set 8 12/06/12, 10:07
-
Markus Klein commented on patch set 8 12/06/12, 10:07
Sorry Olly, didn't see your comment before pushing Set 8. -
Markus Klein uploaded patch set 9 12/06/12, 10:07
-
Dmitry Dulepov commented on patch set 10 1 comment 12/06/12, 10:07
I would prefer that you didn't submit this Sorry to give a -1 to a useful patch but there is one moment there I did not like. Please, see my inline comment. -
Markus Klein uploaded patch set 10 12/06/12, 10:07
-
Dmitry Dulepov uploaded patch set 12 12/06/12, 10:07
-
Dmitry Dulepov commented on patch set 12 V 0 12/06/12, 10:07
by team member; Looks good to me, approved -
Markus Klein uploaded patch set 11 12/06/12, 10:07
-
Oliver Klee commented on patch set 2 12/06/12, 10:07
Looks good to me, but someone else must approveclass.tslib_fe.php:3237JSImgCode -> jsImgCode (so we have proper camelCase)class.tslib_fe.php:3237ReplyYes, that's what I meant. Sorry for the confusion.class.tslib_fe.php:3251JSCode -> jsCodeclass.tslib_fe.php:3265additionalCSS -> additionalCss -
Oliver Klee commented on patch set 2 12/06/12, 10:07
(3 inline comments) -
Oliver Klee commented on patch set 2 12/06/12, 10:07
(1 inline comment) -
Oliver Klee commented on patch set 4 12/06/12, 10:07
Looks good to me, but someone else must approve
-
Oliver Klee commented on patch set 5 12/06/12, 10:07
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 6 12/06/12, 10:07
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 6 12/06/12, 10:07
(1 inline comment) -
Oliver Klee commented on patch set 8 12/06/12, 10:07
Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 7 2 comments 12/06/12, 10:07
Fails; I would prefer that you didn't submit this I did not follow all comments - but was is causing this issue? The mentioned members expect array, so with functionality puts regular strings there? -
Xavier Perseguers commented on patch set 5 12/06/12, 10:07
Verified; Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 6 12/06/12, 10:07
(2 inline comments) -
Georg Ringer commented on patch set 5 12/06/12, 10:07
Verified; Looks good to me, but someone else must approveclass.tslib_fe.php:3261you can remove the access tag and set the function actually to private -
Sebastian Fischer commented on patch set 8 12/06/12, 10:07
Looks good to me, but someone else must approve -
Razakanirina voted on patch set 2 V 0 12/06/12, 10:07
-
Razakanirina commented on patch set 2 12/06/12, 10:07
Looks good to me, but someone else must approve -
Razakanirina commented on patch set 5 12/06/12, 10:07
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 12/06/12, 10:07
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2583/ : FAILURE -
Mr. Jenkins commented on patch set 2 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2584/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2809/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2810/ : SUCCESS -
Mr. Jenkins commented on patch set 5 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2818/ : SUCCESS -
Mr. Jenkins commented on patch set 6 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3152/ : SUCCESS -
Mr. Jenkins commented on patch set 7 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3654/ : SUCCESS -
Mr. Jenkins commented on patch set 8 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3656/ : SUCCESS -
Mr. Jenkins commented on patch set 9 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6006/ : SUCCESS -
Mr. Jenkins commented on patch set 10 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6008/ : SUCCESS -
Mr. Jenkins commented on patch set 11 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6118/ : SUCCESS -
Mr. Jenkins commented on patch set 12 12/06/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6975/ : SUCCESS -
Dmitry Dulepov merged patch set 12 12/06/12, 10:07