70440[TASK] Enhance documentation for integration of html-sanitizer
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Tomas Norre Mikkelsen +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Tomas Norre Mikkelsen +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1618
-
Tomas Norre Mikkelsen uploaded patch set 1 08/11/21, 05:46
-
core-ci voted on patch set 1 V +1 08/11/21, 05:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14531
-
Oliver Hader commented on patch set 1 CR -1 08/11/21, 06:26
On it... -
Oliver Hader uploaded patch set 2 08/11/21, 07:12
-
Oliver Hader voted on patch set 2 V +1 CR +1 08/11/21, 07:15
-
Oli Bartsch voted on patch set 2 V +1 CR +1 08/11/21, 07:24
-
core-ci voted on patch set 2 V +1 08/11/21, 07:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14538
-
Tomas Norre Mikkelsen voted on patch set 2 V +1 CR +1 08/11/21, 07:48
-
Tomas Norre Mikkelsen commented on patch set 2 V 0 CR 0 08/11/21, 07:51
Important-94484-IntroduceHTMLSanitizer.rst:202Shouldn't this be `typo3temp/var/logs/` instead of `log` -
Oliver Hader commented on patch set 2 08/11/21, 07:57
Important-94484-IntroduceHTMLSanitizer.rst:202ReplyAck -
Oliver Hader commented on patch set 2 08/11/21, 07:59
Important-94484-IntroduceHTMLSanitizer.rst:202ReplyIt's `~/log/`... I guess in older versions it was `~/logs/` -
Oliver Hader commented on patch set 2 08/11/21, 08:00
Important-94484-IntroduceHTMLSanitizer.rst:202ReplyYepp, TYPO3 v8 was using `typo3temp/var/logs`, which changed in TYPO3 v9 -
Oliver Hader voted on patch set 2 V +2 CR +2 08/11/21, 08:02
-
Oliver Hader merged patch set 3 08/11/21, 08:03
-
Tomas Norre Mikkelsen commented on patch set 3 V +1 CR +1 08/11/21, 08:12
Important-94484-IntroduceHTMLSanitizer.rst:202ReplyThen it's only because I'm still on an old version 😊 -
Oliver Hader commented on patch set 3 08/11/21, 09:39
Some other warnings as shown in https://docs.typo3.org/c/typo3/cms-core/master/en-us/_buildinfo/warnings.txt might be addressed as well.Important-94484-IntroduceHTMLSanitizer.rst:204Should have been `.. code-block:: text` -
Oliver Hader commented on patch set 3 08/11/21, 09:44
Important-94484-IntroduceHTMLSanitizer.rst:204ReplyAddressed in follow-up https://review.typo3.org/c/Packages/TYPO3.CMS/+/70446 -
Tomas Norre Mikkelsen commented on patch set 3 10/18/26, 15:00
Unresolved
To be honest I haven't been logged in to gerrit for a long long time. I saw this is open on my Dashboard. Are there still to-dos? In the headline is says merged. But honestly in doubt.