70441[FEATURE] Improve the pagination of IndexedSearch
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-94798-IndexedSearchViewHelpers.rstnew+61 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-94798-ImprovedPaginationOfIndexed_search.rst1new+26 −0
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+11 −0
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingResultsViewHelper.php+1 −0
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php2+1 −0
- typo3/sysext/indexed_search/Classes/ViewHelpers/PaginationItemsViewHelper.php8new+132 −0
- typo3/sysext/indexed_search/Resources/Private/Templates/Search/Search.html+23 −4
Review log 1723
-
Georg Ringer uploaded patch set 1 08/11/21, 06:45
-
Georg Ringer commented on patch set 1 08/11/21, 06:46
This change is ready for review. -
core-ci voted on patch set 1 V +1 08/11/21, 06:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14533
-
Benni Mack wrote 11/29/21, 10:10
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:24
-
core-ci voted on patch set 2 V +1 11/29/21, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20017
-
Georg Ringer rebased onto patch set 3 05/10/22, 06:30
-
core-ci voted on patch set 3 V -1 05/10/22, 06:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27074
-
Georg Ringer uploaded patch set 4 05/10/22, 06:46
-
core-ci voted on patch set 4 V +1 05/10/22, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27075
-
Oliver Klee commented on patch set 4 05/10/22, 10:54
PageBrowsingViewHelper.php:30We need to adjust these version numbers: @deprecated since TYPO3 v12, will be removed in TYPO3 v13.0. -
Stefan Bürk commented on patch set 4 05/11/22, 12:32
PaginationItemsViewHelper.php:31Can we make this viewhelper final ? v12 has made a lot of viewhelper final. -
Stefan Bürk uploaded patch set 5 05/28/22, 21:05
-
Stefan Bürk commented on patch set 5 05/28/22, 21:05
PageBrowsingViewHelper.php:30ReplyDonePaginationItemsViewHelper.php:31ReplyDone -
core-ci voted on patch set 5 V +1 05/28/22, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27530
-
Oliver Klee wrote 06/10/22, 21:42
Removed cc Oliver Klee. -
Georg Ringer rebased onto patch set 6 07/21/22, 19:13
-
core-ci voted on patch set 6 V +1 07/21/22, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29407
-
Guido Schmechel commented on patch set 6 07/23/22, 13:13
PaginationItemsViewHelper.php:95I don't quite understand this passage here? -
Stefan Bürk commented on patch set 6 07/29/22, 22:08
PaginationItemsViewHelper.php:4Unresolvedmissing empty linePaginationItemsViewHelper.php:95Reply UnresolvedI think this is copy&paste error from the old viewhelper, where the if-then/else return different strings (based on the label). As here $labe is a array instead of a string, this is superflous. This check is now handled in the template, which uses the registered $items array. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70441/6/typo3/sysext/indexed_search/Resources/Private/Templates/Search/Search.html#82 Good catch ! -
Stefan Bürk commented on patch set 6 07/29/22, 22:20
Feature-94798-ImprovedPaginationOfIndexed_search.rst:16UnresolvedMaybe we should make clear, that the viewhelp do not "returns" this inforation. It registers a $items array to view instead, which can than be used later in the template. I think, this should be made clear ! Also, that the name of the variable, which is set with the ``` $items = [ 'currentPage' => (int)123, 'pages' => [ ['label' => (string)'', 'onclick' => (string)'', 'page' => (int)1,], ['label' => (string)'', 'onclick' => (string)'', 'page' => (int)2,], //... ], ]; ```PaginationItemsViewHelper.php:28UnresolvedThis sentence is kind broken ....PaginationItemsViewHelper.php:29UnresolvedEven internal, can we add a comment with the "structure" which is registered as variabel with the name `argument: as (required)` ? (like in the docs) ? Eventually with a "example" how this viewhelper has to be used.PaginationItemsViewHelper.php:117UnresolvedCan we add a PHPStan array shape definition here ? -
Oliver Klee commented on patch set 6 07/16/23, 11:13
@Georg: Is this change still relevant? And would you be willing to rebase this change and update according to the review comments? -
Georg Ringer abandoned the change 09/27/23, 18:58
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/81267