Review main Abandoned

70441[FEATURE] Improve the pagination of IndexedSearch

Georg Ringer CR 0 V 0 Hard +255 −4 updated 09/27/23, 18:58

Commit message

Introduce a new ViewHelper to IndexedSearch which makes it possible
to adopt the markup of the pagination and deprecate the old ones.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 1723

  1. Georg Ringer uploaded patch set 1 08/11/21, 06:45

  2. Georg Ringer commented on patch set 1 08/11/21, 06:46

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 08/11/21, 06:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14533

  4. Benni Mack wrote 11/29/21, 10:10

    Change destination moved from master to main
  5. Benni Mack updated the commit message in patch set 2 11/29/21, 13:24

  6. core-ci voted on patch set 2 V +1 11/29/21, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20017

  7. Georg Ringer rebased onto patch set 3 05/10/22, 06:30

  8. core-ci voted on patch set 3 V -1 05/10/22, 06:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27074

  9. Georg Ringer uploaded patch set 4 05/10/22, 06:46

  10. core-ci voted on patch set 4 V +1 05/10/22, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27075

  11. Oliver Klee commented on patch set 4 05/10/22, 10:54

    PageBrowsingViewHelper.php:30

    We need to adjust these version numbers: @deprecated since TYPO3 v12, will be removed in TYPO3 v13.0.
  12. Stefan Bürk commented on patch set 4 05/11/22, 12:32

    PaginationItemsViewHelper.php:31

    Can we make this viewhelper final ? v12 has made a lot of viewhelper final.
  13. Stefan Bürk uploaded patch set 5 05/28/22, 21:05

  14. Stefan Bürk commented on patch set 5 05/28/22, 21:05

    PageBrowsingViewHelper.php:30 Reply

    Done

    PaginationItemsViewHelper.php:31 Reply

    Done
  15. core-ci voted on patch set 5 V +1 05/28/22, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27530

  16. Oliver Klee wrote 06/10/22, 21:42

    Removed cc Oliver Klee.
  17. Georg Ringer rebased onto patch set 6 07/21/22, 19:13

  18. core-ci voted on patch set 6 V +1 07/21/22, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29407

  19. Guido Schmechel commented on patch set 6 07/23/22, 13:13

    PaginationItemsViewHelper.php:95

    I don't quite understand this passage here?
  20. Stefan Bürk commented on patch set 6 07/29/22, 22:08

    PaginationItemsViewHelper.php:4 Unresolved

    missing empty line

    PaginationItemsViewHelper.php:95 Reply Unresolved

    I think this is copy&paste error from the old viewhelper, where the if-then/else return different strings (based on the label). As here $labe is a array instead of a string, this is superflous. This check is now handled in the template, which uses the registered $items array. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70441/6/typo3/sysext/indexed_search/Resources/Private/Templates/Search/Search.html#82 Good catch !
  21. Stefan Bürk commented on patch set 6 07/29/22, 22:20

    Feature-94798-ImprovedPaginationOfIndexed_search.rst:16 Unresolved

    Maybe we should make clear, that the viewhelp do not "returns" this inforation. It registers a $items array to view instead, which can than be used later in the template. I think, this should be made clear ! Also, that the name of the variable, which is set with the ``` $items = [ 'currentPage' => (int)123, 'pages' => [ ['label' => (string)'', 'onclick' => (string)'', 'page' => (int)1,], ['label' => (string)'', 'onclick' => (string)'', 'page' => (int)2,], //... ], ]; ```

    PaginationItemsViewHelper.php:28 Unresolved

    This sentence is kind broken ....

    PaginationItemsViewHelper.php:29 Unresolved

    Even internal, can we add a comment with the "structure" which is registered as variabel with the name `argument: as (required)` ? (like in the docs) ? Eventually with a "example" how this viewhelper has to be used.

    PaginationItemsViewHelper.php:117 Unresolved

    Can we add a PHPStan array shape definition here ?
  22. Oliver Klee commented on patch set 6 07/16/23, 11:13

    @Georg: Is this change still relevant? And would you be willing to rebase this change and update according to the review comments?
  23. Georg Ringer abandoned the change 09/27/23, 18:58