Review main Merged

70453[BUGFIX] Prevent nested returnUrl parameters in DatabaseRecordList

Oli Bartsch CR +2 V +2 Easy +5 −15 updated 08/11/21, 16:09

Commit message

The clipboard copy and cut actions do not longer define a returnUrl,
since the action does not switch the module. This previously led to
an endless loop of returnUrl parameters being added to the link.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Oli Bartsch uploaded patch set 1 08/11/21, 14:01

  2. Oli Bartsch commented on patch set 1 CR -1 08/11/21, 14:08

    Will solve differently
  3. core-ci voted on patch set 1 V +1 08/11/21, 14:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14601

  4. Oli Bartsch uploaded patch set 2 08/11/21, 15:02

  5. Oli Bartsch uploaded patch set 3 08/11/21, 15:06

  6. core-ci voted on patch set 2 V +1 08/11/21, 15:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14606

  7. core-ci voted on patch set 3 V +1 08/11/21, 15:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14607

  8. Oli Bartsch uploaded patch set 4 08/11/21, 15:28

  9. core-ci voted on patch set 4 V +1 08/11/21, 15:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14612

  10. Jochen Roth voted on patch set 4 V +1 CR +1 08/11/21, 16:01

  11. Benni Mack voted on patch set 4 V +2 CR +2 08/11/21, 16:09

  12. Benni Mack merged patch set 5 08/11/21, 16:09