70454[TASK] Remove rel="shortcut" from page.shortcutIcon output
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1114
-
Christoph Schwob uploaded patch set 1 08/11/21, 15:29
-
core-ci voted on patch set 1 V -1 08/11/21, 15:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14613
-
Georg Ringer uploaded patch set 2 08/12/21, 06:48
-
core-ci voted on patch set 2 V +1 08/12/21, 07:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14653
-
Wouter Wolters voted on patch set 2 V +1 CR +1 08/12/21, 10:00
-
Benni Mack commented on patch set 2 08/12/21, 10:36
side-note: IE10 and lower does not support this (and since this is also related to frontend output, I wanted to note this) -
Christian Kuhn commented on patch set 2 CR -1 08/12/21, 11:20
"Update: For historical reasons, the HTML specification now allows the use of shortcut as a link relation if it’s immediately followed by a single U+0020 space character and the icon keyword. Of course, it’s still better not to use any HTML at all." https://mathiasbynens.be/notes/rel-shortcut-icon I'm fine with dropping shortcut here for v11, but we may just simply keep it for v10 since it changes html output of the site and we probably shouldn't risk *any* possible side-effect in v10. So, I'd prefer: +1 for master, but let's drop v10 to not risk anything. Agreed? -
Christian Kuhn commented on patch set 2 08/12/21, 11:28
I'll go ahead and drop v10 from the releases list. Hope that is ok for everybody. -
Christian Kuhn updated the commit message in patch set 3 08/12/21, 11:29
-
core-ci voted on patch set 3 V +1 08/12/21, 11:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14709
-
Georg Ringer voted on patch set 3 V +1 CR +1 08/12/21, 12:04
-
Wouter Wolters voted on patch set 3 V +1 CR +1 08/12/21, 12:08
-
Christian Kuhn voted on patch set 3 V +2 CR +2 08/12/21, 12:08
-
Christian Kuhn merged patch set 4 08/12/21, 12:08