Review main Merged

70511[DOCS] Add missing links to rst files

Nikita Hovratov CR +2 V +2 Easy +6 −6 updated 08/29/21, 19:27

Commit message

This fixes some links to related rst files.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Nikita Hovratov uploaded patch set 1 08/12/21, 16:59

  2. Christian Kuhn commented on patch set 1 08/12/21, 17:02

    i think the preferred solution is for example :doc:`FileViewHelper <../11.3/Feature-92518-IntroduceFileViewHelper>` this way the ref anchors in single files are not needed. the only issue is that this strategy fails for links to docs files in master/, since those will be moved to for instance 11.4 later. but we could argue those :doc: references need to be adapted at this time, too.
  3. core-ci voted on patch set 1 V +1 08/12/21, 17:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14808

  4. Nikita Hovratov commented on patch set 1 08/12/21, 17:42

    Reply

    Ah, I see. Right now both solutions are used. Maybe we can streamline all files then in another patch?
  5. Nikita Hovratov uploaded patch set 2 08/12/21, 17:49

  6. Christian Kuhn commented on patch set 2 08/12/21, 18:00

    Reply

    would be great.
  7. core-ci voted on patch set 2 V -1 08/12/21, 18:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14818

  8. Nikita Hovratov commented on patch set 2 08/12/21, 18:18

    > Patch Set 2: Verified-1 > > Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14818 Our friend #recordlist-sys_language again
  9. Nikita Hovratov rebased onto patch set 3 08/16/21, 15:13

  10. core-ci voted on patch set 3 V +1 08/16/21, 15:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15192

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/23/21, 22:49

  12. Tymoteusz Motylewski voted on patch set 3 V +2 CR +2 08/29/21, 19:27

  13. Tymoteusz Motylewski merged patch set 4 08/29/21, 19:27