Review main Merged

70520[BUGFIX] Fix FileSpoolTest creating "spool" directory on root level

Wouter Wolters CR +2 V +2 Easy +2 −1 updated 08/13/21, 11:13

Commit message

The FileSpoolTest is creating a directory "spool" on root level.
Unit tests should never create directories on the root level of
TYPO3 project. Instead use `Environment::getVarPath()` as path.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Marcin Sągol +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Marcin Sągol +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Wouter Wolters uploaded patch set 1 08/12/21, 19:19

  2. Simon Gilli voted on patch set 1 CR +1 08/12/21, 19:23

  3. Simon Gilli voted on patch set 1 V +1 08/12/21, 19:33

  4. core-ci voted on patch set 1 V -1 08/12/21, 19:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14836

  5. core-ci voted on patch set 1 V +1 08/12/21, 20:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14836

  6. Rudy Gnodde voted on patch set 1 CR +1 08/13/21, 09:50

  7. Marcin Sągol voted on patch set 1 V +1 CR +1 08/13/21, 10:37

  8. Benni Mack voted on patch set 1 V +2 CR +2 08/13/21, 11:13

  9. Benni Mack merged patch set 2 08/13/21, 11:13