Review main Merged

70524[TASK] Add test method prefix checker to gitlab-ci

Wouter Wolters CR +2 V +2 Normal +117 −0 updated 08/13/21, 21:10

Commit message

Test methods are not allowed to have a prefix "test".
Use the annotation "@test" in phpDoc instead.

Integration into pre-merge and nightly gitlab-ci suites.

Note we now have multiple tests based on nikic/php-parser.
Those should be rewritten to use one parser instance with
multiple visitors to scan php code only once. The
exception code checker should be rewritten to use
the parser, too. This will be done with a dedicated patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5