70546[BUGFIX] Fix queryGenerator count result with deleted entries
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Jonas Eberle +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- kharaf +1
- Jonas Eberle +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1315
-
Andrzej Kołbuc uploaded patch set 1 08/13/21, 11:02
-
core-ci voted on patch set 1 V +1 08/13/21, 11:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14939
-
Wouter Wolters voted on patch set 1 CR +1 08/13/21, 12:02
-
kharaf commented on patch set 1 V +1 CR +1 08/13/21, 12:28
bugfix is ok! -
Rudy Gnodde voted on patch set 1 CR +1 08/13/21, 14:27
-
Tymoteusz Motylewski commented on patch set 1 CR -1 08/18/21, 14:51
QueryGenerator.php:362what about changing isset($this->settings['show_deleted']) && $this->settings['show_deleted']) to !empty($this->settings['show_deleted']) -
Andrzej Kołbuc uploaded patch set 2 08/22/21, 08:16
-
core-ci voted on patch set 2 V +1 08/22/21, 08:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15374
-
Andrzej Kołbuc commented on patch set 2 08/22/21, 08:35
Condition for "show_deleted" was changed. Also, I rollback unnecessary changes in function search() - it`s for "Raw search in all fields" view that does not have"show_deleted" checkboxQueryGenerator.php:362ReplyOk, I made that changes at patch set 2. Other similar conditions was changed too. -
Tymoteusz Motylewski voted on patch set 2 CR +1 08/29/21, 19:07
-
kharaf commented on patch set 2 V +1 08/30/21, 09:11
Everything is ok, checkbox displays correctly -
Tymoteusz Motylewski voted on patch set 2 V +1 08/30/21, 10:45
-
Jonas Eberle voted on patch set 2 V +1 CR +1 08/31/21, 07:20
-
Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/31/21, 12:48
-
Tymoteusz Motylewski merged patch set 3 08/31/21, 12:48