Review main Merged

70581[BUGFIX] Fix columns selector action buttons

Oli Bartsch CR +2 V +2 Normal +41 −38 updated 08/13/21, 15:00

Commit message

The columns selector actions buttons did previously
not respond when clicking on their icon.

This is fixed by adding the event listener to the
corresponding buttons instead of the outer
container and by accessing the required data
attribute from `event.currentTarget`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 08/13/21, 14:33

  2. Jochen Roth voted on patch set 1 V +1 CR +1 08/13/21, 14:40

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/13/21, 14:41

  4. core-ci voted on patch set 1 V +1 08/13/21, 14:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14985

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 08/13/21, 15:00

  6. Oli Bartsch merged patch set 2 08/13/21, 15:00