Review main Abandoned

70596[FEATURE] Add renderAsButton option to BackendUtility::cshItem

Marcin Sągol CR 0 V 0 Normal +48 −12 updated 06/08/22, 06:26

Commit message

The new fifth argument "$renderAsButton" of BackendUtility::cshItem is
a bool flag. It allows to return the csh help link as a button by
applying bootstrap button classes to it.

This helps to solve another issue:

In the module doc header there is a button group, which, among other
buttons, renders a csh help link button.

The PageLayoutController used the HelpButton class to render this button
by wrapping the output returned by the BackendUtility::cshItem
method with an extra span element.

The problem was, that the button itself didn't trigger the csh link, but
only the "help-link" class of the question mark icon.

With this feature, the button class is applied directly to the event
listening element.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5