Review main Abandoned

70680[FEATURE] Introduce "smart content container" content element

waldhacker CR 0 V 0 Nightmare +4761 −3 updated 06/11/23, 23:03

Commit message

The new content element "smart content container" is the MVP of a
content element based on fluid_styled_content which is able to display
a set of referenced content elements (content pool) using various
configuration options in the frontend.
The "smart content container" automatically detects if there are content
elements outside the "smart content container" on a page and does not
display these content elements inside the "smart content container".
Not only individual content elements can be referenced in the
content pool but also entire categories of content elements.
The "smart content container" then takes care of collecting and
displaying the displayable content elements from the category.
With the "smart content container" it is easy to create something
like "recommended content" lists and make sure that the content of
the page does not overlap with the content of the "recommended content"
list.

todo:

* the content element needs a new icon

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 27

Show 7 more files

Review log 1830

Show 35 earlier messages
  1. waldhacker uploaded patch set 1 08/18/21, 18:35

  2. waldhacker updated the commit message in patch set 2 08/18/21, 18:36

  3. waldhacker marked it work in progress 08/18/21, 18:37

  4. core-ci voted on patch set 1 V +1 08/18/21, 18:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15283

  5. core-ci voted on patch set 2 V +1 08/18/21, 19:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15284

  1. waldhacker uploaded patch set 3 08/20/21, 00:00

  2. core-ci voted on patch set 3 V +1 08/20/21, 00:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15315

  3. waldhacker uploaded patch set 4 08/23/21, 18:25

  4. waldhacker uploaded patch set 5 08/23/21, 18:52

  5. waldhacker uploaded patch set 6 08/23/21, 19:03

  6. waldhacker uploaded patch set 7 08/23/21, 19:12

  7. waldhacker uploaded patch set 8 08/23/21, 20:07

  8. core-ci voted on patch set 8 V +1 08/23/21, 20:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15462

  9. core-ci voted on patch set 4 V -1 08/23/21, 20:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15443

  10. waldhacker rebased onto patch set 9 08/23/21, 20:38

  11. waldhacker marked it ready for review 08/23/21, 20:39

  12. waldhacker updated the commit message in patch set 10 08/23/21, 20:44

  13. core-ci voted on patch set 9 V +1 08/23/21, 20:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15466

  14. core-ci voted on patch set 5 V -1 08/23/21, 20:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15450

  15. core-ci voted on patch set 10 V +1 08/23/21, 21:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15468

  16. core-ci voted on patch set 6 V -1 08/23/21, 21:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15452

  17. core-ci voted on patch set 7 V -1 08/23/21, 21:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15455

  18. waldhacker rebased onto patch set 11 08/25/21, 05:13

  19. core-ci voted on patch set 11 V +1 08/25/21, 05:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15556

  20. Benni Mack wrote 11/29/21, 10:10

    Change destination moved from master to main
  21. Benni Mack updated the commit message in patch set 12 11/29/21, 13:25

  22. core-ci voted on patch set 12 V +1 11/29/21, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20021

  23. Chris Müller commented on patch set 12 02/13/22, 18:45

    Feature-94929-IntroduceSmartContentContainerContentElement.rst:12 Unresolved

    What does "MVP" mean?
  24. Christian Kuhn commented on patch set 12 06/11/23, 23:03

    hey. i hope it's ok to abandon here for now: this patch stalled and it seems as if active development on it is unlikely. we'll remove it from the review queue, a new patch can be pushed if this topic is picked up again.
  25. Christian Kuhn abandoned the change 06/11/23, 23:03