Review main Merged

70683[TASK] Clean up EXT:impexp export folder after test run

Alexander Nitsche CR +2 V +2 Easy +14 −6 updated 08/23/21, 15:45

Commit message

Running the functional EXT:impexp tests causes the
EXT:impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload
folder to grow larger. This is due to export files being created that
have not been cleaned up after the tests have run.

In addition, completely delete the default import/export folder
in ImportExport::removeDefaultImportExportFolder(). This
method is currently only used in tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Alexander Nitsche uploaded patch set 1 08/19/21, 15:37

  2. core-ci voted on patch set 1 V +1 08/19/21, 15:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15307

  3. Alexander Nitsche updated the commit message in patch set 2 08/19/21, 15:55

  4. Alexander Nitsche commented on patch set 2 08/19/21, 15:59

    Test this patch by running ``` ./Build/Scripts/runTests.sh -s functional -d mariadb -i 10.3 -p 8.0 -e "-v typo3/sysext/impexp/Tests/Functional" ``` once before and once after this patch being applied. On the first run there should be 3 files created in EXT:impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload. On the second run this folder should not contain new files.
  5. core-ci voted on patch set 2 V +1 08/19/21, 16:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15308

  6. Stefan Bürk commented on patch set 2 V +1 CR +1 08/19/21, 16:17

    Looks good to me, before leaving rests, after cleaned up.
  7. Christian Kuhn voted on patch set 2 V +2 CR +2 08/23/21, 15:45

  8. Christian Kuhn merged patch set 3 08/23/21, 15:45