Review main Merged

70718[BUGFIX] Correct decision about new content button

Claus Due CR +2 V +2 Easy +9 −6 updated 09/09/21, 12:42

Commit message

This patch fixes an issue with mod.web_layout.defLangBinding = 1
which when enabled would cause the page layout module to
render the "new content" buttons when this was not desired.

The fixes consist of:

* A change to make sure that Fluid variable {column} contains
  the right language ID in the PageLayoutContext associated
  with the column; by re-assigning {column} within the loop
  over {languageColumns} in LanguageColumns.html
* Re-overwriting the {column} variable after the loop to ensure
  it holds the default language column which holds the default
  language column's content records that are iterated over.
* Overwriting the {column} variable within the loop that renders
  each content record to ensure it holds the correct language ID
  in the column's PageLayoutContext.
* Assigning the right PageLayoutContext to translated versions
  of content records to ensure that the "new content" button
  below each translated content element points to the right
  language UID.
* A visual alignment fix setting valign="top" on TD elements
  to ensure the alignment of each content record and the
  column header, when the "new content" button is not shown.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3