Review main Merged

70721[TASK] Deprecate ContentObjectRenderer constructor in StandaloneView

Christian Kuhn CR +2 V +2 Normal +72 −9 updated 08/26/21, 09:36

Commit message

Handling ContentObjectRenderer instances is messy, especially
within extbase: The ConfigurationManager is a stateful singleton
since it depends on current ContentObjectRenderer being set
within frontend. The extbase Bootstrap takes care of setting the
current cObj.

ConfigurationManager is also misused (ext:form) to "park" the
current cObj for later retrieval. This needs to be tackled with
a dedicated patch.

This is worse with fluid StandaloneView, which accepts cObj as
constructor argument to update ConfigurationManager state.
Funnily, this optional constructor argument is never hand
over in core. Additionally, extbase usually does not use
StandaloneView, but fluid's TemplateView instead.

The patch deprecates the constructor argument of fluid
StandaloneView to avoid a dependency from StandaloneView
to extbase.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6