70729[TASK] Require symfony/filesystem as direct dependency
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1217
-
Wouter Wolters uploaded patch set 1 08/23/21, 19:10
-
Wouter Wolters updated the commit message in patch set 2 08/23/21, 19:11
-
Simon Gilli commented on patch set 2 08/23/21, 19:16
Two minor possible changes.composer.json:68UnresolvedWhat about also adding the patch number like done for the other SF packages?composer.json:55UnresolvedSame as for root -
core-ci voted on patch set 1 V +1 08/23/21, 19:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15453
-
core-ci voted on patch set 2 V +1 08/23/21, 19:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15454
-
Christian Kuhn commented on patch set 2 08/23/21, 21:55
confirmed. symfony/filesystem should be defined as explicit dependency. good catch. -
Wouter Wolters uploaded patch set 3 08/24/21, 17:32
-
Wouter Wolters uploaded patch set 4 08/24/21, 17:33
-
core-ci voted on patch set 3 V +1 08/24/21, 17:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15525
-
core-ci voted on patch set 4 V +1 08/24/21, 18:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15526
-
Andreas Kienast voted on patch set 4 V +1 CR +1 08/24/21, 18:40
-
Oli Bartsch updated the commit message in patch set 5 08/24/21, 20:14
-
Oli Bartsch voted on patch set 5 V +1 CR +1 08/24/21, 20:14
-
Andreas Kienast voted on patch set 5 V +1 CR +1 08/24/21, 20:15
-
core-ci voted on patch set 5 V +1 08/24/21, 20:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15533
-
Oli Bartsch voted on patch set 5 V +2 CR +2 08/24/21, 20:31
-
Oli Bartsch merged patch set 6 08/24/21, 20:33