Review main Merged

70732[TASK] Avoid calling inline JavaScript jump()

Benni Mack CR +2 V +2 Hard +170 −89 updated 08/27/21, 10:14

Commit message

LiveSearch, Shortcut and OpenDocs call jump()
and thus, uses some "magic" top-level variables
to store the actual URL to go to.

This is not ideal, and the ModuleMenu should resolve
this, preserve the state of the "id" parameter,
open the content frame and (optionally) select a module
which was in use.

The global functions and variables are deprecated now:
* top.currentSubScript
* top.currentModuleLoaded
* top.nextLoadModuleUrl
* jump()

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 24

Show 4 more files