Review main Merged

70759[TASK] Move metadata translation to action button in filelist

Oli Bartsch CR +2 V +2 Normal +98 −108 updated 08/26/21, 09:42

Commit message

Creating and editing file metadata translations is usually
done in the filelist module. Therefore a custom toggle
button in the "Localization" column had to be used.

In the expanded state, various flag icons with an hard
to guess overlay icon were displayed. Those could be
used to either create or edit the file metadata records.

This however had some drawbacks:

- The toggle button was not accessible by keyboard
- As toggle icon, the "pages languages overlay" icon
  was used, making it hard to understand for editors
- As soon as one of those toggle buttons was clicked,
  all other toggle buttons jumped to the left

To improve this, the toggle button is moved into the
controls group and does now uses the "actions-translate"
icon. It furthermore does now open a dropdown with
proper link labels - as already known from the secondary
menu. This therefore also increases consistency.

Besides the visual changes, this patch also cleans
up the underlying code and removes the custom
JavaScript component, which was used for the
toggle button.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5