Review main Merged

70817[TASK] Change icon of TOTP provider to "actions-qrcode"

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 08/30/21, 09:16

Commit message

Since its introduction, the TOTP provider used
the "content-coffee" icon, which did obviously
not really suit here. Therefore, the TOTP provider
is now using the "actions-qrcode" icon, as a
reference on how TOTP can be set up.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 08/30/21, 08:29

  2. core-ci voted on patch set 1 V +1 08/30/21, 08:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15843

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/30/21, 09:08

  4. Benjamin Franzke commented on patch set 1 V +2 CR +2 08/30/21, 09:16

    Hm, yes, reference to the setup, but not really to the usage. Anyway, better than the icon before, and fine for this context, so I'll merge this…
  5. Benjamin Franzke merged patch set 2 08/30/21, 09:16