Review main Merged

70825[TASK] Do not handle component specific logic in multi record selection

Oli Bartsch CR +2 V +2 Normal +100 −55 updated 08/30/21, 20:08

Commit message

The multi record selection component is responsible
for managing the selection of records as well as
toggling the corresponding actions. It should not
implement any component specific action logic,
but just dispatch a custom event, informing the
component about the requested action.

Therefore, the "edit file metadata" handling is
moved into the corresponding FileList component.

To make life easier for implementing components, the
details, any dispatched action event contains, are now
extended for the action specific configuration.

Furthermore are the ActionConfiguration and
ActionEventDetails interfaces now properly exported.
This allows to increase type safety in the implementing
components.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 56

  1. Oli Bartsch uploaded patch set 1 08/30/21, 18:23

  2. core-ci voted on patch set 1 V +1 08/30/21, 18:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15891

  3. Jochen Roth voted on patch set 1 V +1 CR +1 08/30/21, 19:03

  4. Benni Mack voted on patch set 1 V +1 CR +1 08/30/21, 20:02

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 08/30/21, 20:08

  6. Oli Bartsch merged patch set 2 08/30/21, 20:08