Review main Merged

70830[BUGFIX] Exclude Build/composer/ from typescript build

Benjamin Franzke CR +2 V +2 Easy +6 −3 updated 09/01/21, 14:58

Commit message

The Build/composer/ directory (recently added in 95046 )
contains all core files (symlinked) once `composer install`
has been executed, that means both typoscript and typescript
files that end with .ts. This leads to compilation errors.

These files must actually be ignored by `tsc` during `grunt build`.
and should not be compiled at all (wasted ressources).

While at it we also fix the tsconfig.json to include
a trailing newline, in order to comply to our coding guidelines.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2