Review main Merged

70831[TASK] Implement interface for ViewHelperResolverFactory

Benjamin Tammling CR +2 V +2 Normal +43 −8 updated 09/02/21, 18:06

Commit message

Add ViewHelperResolverFactoryInterface and use it for
dependency injection.

ViewHelperResolverFactoryInterface is specified via
ServiceProvider.php since it is needed in FailsafeContainer
(install tool). Since ServiceProdiver.php itself is not API,
ViewHelperResolverFactoryInterface isn't either. This will
evolve over time in core. For now, we still need this
interface already for some extensions edge cases, though.

ServiceProviderCompilationPass is adapted to avoid
alias resolution when providing factories for interfaces.
Otherwise the aliased service is configured instead of
the interface itself.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5