Review main Merged

70836[BUGFIX] Keep original request language for shortcuts

Nikita Hovratov CR +2 V +2 Normal +137 −4 updated 05/10/22, 11:35

Commit message

In #89871 (65dc060) a fix was introduced, that
forces the link generation to use the requested
language of shortcuts instead of the current
language of the frontend.

In addition, another call to getPageOverlay was
added. This is in fact not necessary, as overlaying
is already done implicitly in getPageShortcut. This
introduced a falsy behaviour, where shortcuts
without the current language available would create
a URL with the entry point of the fallback language.

This can be fixed by simply using the request
language from the original $menuItem variable before
processing.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3