70846[TASK] Fix undefined array key warning in free mode
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 1
Review log 78
-
Nikita Hovratov uploaded patch set 1 08/31/21, 15:32
-
core-ci voted on patch set 1 V +1 08/31/21, 15:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15953
-
Georg Ringer voted on patch set 1 V +1 CR +1 09/01/21, 09:50
-
Oli Bartsch commented on patch set 1 09/10/21, 00:28
-
Oli Bartsch commented on patch set 1 09/10/21, 09:30
EditDocumentController.php:2175ReplyWill not trigger a warning since there is the `array_key_exists`. However, this therefore still don't make sense to create the $redirectUrl, since the option will then be skipped anyways. -
Oliver Klee voted on patch set 1 CR +1 09/10/21, 09:51
-
Christian Kuhn commented on patch set 1 V +2 CR +2 09/11/21, 10:52
EditDocumentController.php:2175Replycould be cleaned with a dedicated patch. imho patch as is is fine. -
Christian Kuhn merged patch set 2 09/11/21, 10:52
EditDocumentController.php:2175