Review main Merged

70858[TASK] Fix undefined array key error in DataHandler logs

Nikita Hovratov CR +2 V +2 Easy +2 −4 updated 10/04/21, 19:28

Commit message

The variable $log_data does not always have 5 entries. Use the array
spread operator to provide all available entries.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Nikita Hovratov uploaded patch set 1 09/01/21, 13:19

  2. core-ci voted on patch set 1 V +1 09/01/21, 13:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16011

  3. Benni Mack voted on patch set 1 CR +1 09/01/21, 13:37

  4. Wouter Wolters voted on patch set 1 CR +1 09/02/21, 07:27

  5. Oliver Klee voted on patch set 1 CR +1 09/02/21, 09:15

  6. Benni Mack uploaded patch set 2 09/16/21, 15:17

  7. Benni Mack voted on patch set 2 V +1 CR +1 09/16/21, 15:17

  8. core-ci voted on patch set 2 V +1 09/16/21, 15:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16810

  9. Benni Mack uploaded patch set 3 09/17/21, 08:37

  10. core-ci voted on patch set 3 V +1 09/17/21, 08:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16859

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 09/17/21, 09:51

  12. Oliver Klee voted on patch set 3 CR +1 09/17/21, 10:09

  13. Benni Mack voted on patch set 3 V +2 CR +2 09/17/21, 10:18

  14. Benni Mack merged patch set 4 09/17/21, 10:18

  15. Andreas Kienast commented on patch set 4 10/04/21, 19:21

  16. Andreas Kienast wrote 10/04/21, 19:28

    Created a revert of this change as Ib7811f6174d517e4b7c24f53b9e0d93c8914d5a1