Review main Merged

70874[FEATURE] Introduce AfterFileCommandProcessedEvent

Oli Bartsch CR +2 V +2 Normal +199 −10 updated 09/03/21, 20:08

Commit message

A new PSR-14 based event "AfterFileCommandProcessedEvent"
is introduced in favour of the existing
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_extfilefunc.php']['processData']
hook, which is now marked as deprecated, along with
its interface "ExtendedFileUtilityProcessDataHookInterface".

The new event features the same data, however
the way they can be accessed is improved.

The previous `$action` and `$cmdArr` arguments
are now available within the `getCommand()` method,
while the action is the array key and the command
data ($cmdArr) is the value. This is more in line
with the actual request.

The hooks `$result` argument always contained all
results of previous operations, making it unnecessary
complicated to find out the actual result for the
current operation. This is now resolved. The new
`getResult()` method only returns the result for
the currently executed operation.

Finally the "getConflictMode()" method just returns
the conflict mode, used for the current operation.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7