Review main Merged

70890[TASK] Activate a impexp export functional test for postgres

Stefan Bürk CR +2 V +2 Easy +0 −3 updated 09/06/21, 13:28

Commit message

A functional test has been skipped for postgres functional
test execution because it exported relations in not expected
order like other databases. Mainly younger postgres versions
are unreliable when undetermistic queries are used.

Undetermistic database query sorting may lead to unexpected
and random data returns. Generally queries should implement
determistic sortings to mitigate this issue across all
dbms and dbms versions.

The related query for this functional test has been already
made determistic through #95032 and #95045 but missed to
reactive this related functional test.

This patch acts as follow-up for #95045.

Commands:

Build/Scripts/runTests.sh -s functional -d postgres -k 9.6 \
typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 10 \
typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 11 \
typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 12 \
typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 13 \
typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1