Review main Merged

70892[TASK] Enable a flaky marked postgres test as it seems to work

Stefan Bürk CR +2 V +2 Easy +0 −2 updated 09/06/21, 13:31

Commit message

A functional test has been disabled for postgres because the test
was flaky (what ever this meant exactly) and has been leading to
occassional test run failure.

Using git bisect the first working commit has been way back before
v11.0.0 release tag

  27c7de8a6e [!!!][TASK] Remove move placeholders #92497

as the commit before has been failing

  64542d624e [TASK] Decouple Dependency logic and domain models in EM

As the patch which has been fixed the related stuff for the flaky
test is not an easy area (or at least I'm not in ) it is really
hard to identify which exactly in that commit has fixed it.

Anyway, as proven through a lot of checkouts sinces this commit and
even current master (run through nightly) passed all green thus
this test is activated again.

Testcommands:
(on different versions/commits + patch | as available )

Build/Scripts/runTests.sh -s functional -d postgres \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 9.6 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 10 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 11 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 12 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 13 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1