Review main Merged

70914[TASK] Avoid using hook for context menu settings

Oli Bartsch CR +2 V +2 Normal +57 −111 updated 09/09/21, 09:32

Commit message

It's possible to assign additional attributes
to context menu items. Those attributes are
then available in the corresponding JavaScript
callback method.

Therefore, there is no need to add settings,
only used in the callback methods, globally
via BackendController hooks.

This patch removes such hook usages from
EXT:filelist and EXT:impexp, while adding
the corresponding settings as attributes
to the context menu items.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 10