Review main Merged

70984[BUGFIX] Don't toggle selection actions without identifier

Oli Bartsch CR +2 V +2 Easy +1 −5 updated 09/09/21, 19:28

Commit message

Multi record selection was first introduced to filelist,
where only one "table" exists. Therefore, it was
sufficient to toggle all actions, after registering
their events.

With #95017, multi record selection got extended
to be able to handle multiple instances on the same
page. Since then, toggling of actions always requires
to take the corresponding instance identifier into
account. This is properly handled in the
"restoreTemporaryState()" method.

Therefore the toggling, initiated after the event
registration, having no identifier information, is
removed. This fixes toggling the actions of all
instances as soon as one checkbox is checked.

Besides, an unused selector is removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2