Review main Merged

71023[BUGFIX] Avoid endless loading of FormEngine

Oli Bartsch CR +2 V +2 Hard +218 −190 updated 09/16/21, 11:14

Commit message

EditDocumentController failed to properly track if
the edit form could be created or not. This lead
to a couple of consequential errors. For example,
the spinner was added but could never be removed,
since the FormEngine JavaScript component was not
initialized.

With PHP > 8 this also lead to a lot of warnings
since $this->firstEl is not set, in case the edit
form could not be created.

This is now fixed by properly tracking whether the
edit form was created and whether $this->firstEl
was initialized. In case the edit form could not
be created, an info box notifies the user.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2