Review main Merged

71044[TASK] Reduce inline JavaScript of requireJS in FormEngine

Oliver Hader CR +2 V +2 Hard +586 −200 updated 10/01/21, 23:36

Commit message

To reduce arbitrary inline JavaScript, requireJS callbacks used in
FormEngine are streamlined to be more explicit - allowed instructions
are `load` (module), `invoke` (a method), (create a new) `instance`.

This change is an intermediate preparation for delegating loading,
assignment and invocation directly to JavaScript processes. Relevant
parts have been extracted from corresponding client-side handling in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/64123

The possibility to load and append arbitrary inline JavaScript to
FormEngine segment `requireJsModules` is deprecated. Instructions
need to be declared using new `JavaScriptModuleInstruction`.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 41

Show 21 more files