Review main Abandoned

71045[BUGFIX] Fix various "undefined array key" warnings in PageRenderer

Robert Kärner CR 0 V 0 Normal +75 −75 updated 09/12/21, 20:34

Commit message

Adding CSS or JS files with includeCSS, includeJS and
friends in TypoScript causes the frontend to throw
"Undefined array key" warnings.

This is fixed by adding the neccessary checks.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Robert Kärner uploaded patch set 1 09/12/21, 15:36

  2. core-ci voted on patch set 1 V -1 09/12/21, 15:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16624

  3. Jochen Roth commented on patch set 1 09/12/21, 17:21

    See this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70867 Which make the RequestHandler php8 compatible.
  4. Robert Kärner commented on patch set 1 09/12/21, 19:15

    Reply

    Thanks for showing me. I can see that patch 70867 doesn‘t fix all occurrences in RequestHandler, i.e. at includeCSSLibs. Should I create a new patchset with my changes on 70867 and we close this one?
  5. Jochen Roth commented on patch set 1 09/12/21, 19:36

    Reply

    I would suggest to close this one and add your changes to https://review.typo3.org/c/Packages/TYPO3.CMS/+/70867
  6. Robert Kärner commented on patch set 1 09/12/21, 20:33

    Reply

    Will do … tomorrow :) Thanks for your support!
  7. Robert Kärner abandoned the change 09/12/21, 20:34

    Duplicate of patch 70867