Review main Merged

71072[TASK] Deprecate and replace onchange & onclick attrs in FormEngine

Oliver Hader CR +2 V +2 Expert +884 −174 updated 09/24/21, 08:02

Commit message

Previously, `fieldChangeFunc` items have been declared as string and
were forwarded as plain inline JavaScript to the client application
using HTML attrs `onchange` and `onclick`.

This change introduces semantic objects for those `fieldChangeFunc`
items that either can be used as structured configuration (JSON) or
still "serialized" to inline JavaScript for legacy applications. New
`OnFieldChangeInterface` provides a hybrid component that is backward
compatible and still supports inline JavaScript as fallback.

Using scalar (string) instructions for `fieldChangeFunc` will
trigger PHP deprecation errors.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 33

Show 13 more files