Review main Merged

71084[BUGFIX] Fix TypoScriptFrontendController initialization in subrequests

Simon Schaufelberger CR +2 V +2 Normal +29 −28 updated 09/16/21, 17:36

Commit message

With the introduction of #94402 error pages are fetched via a
sub-request. Manual "page not found" ErrorController invocations
within an extbase action then resulted in rendering the originally
requested page instead of the defined 404 page.
This happened because the PrepareTypoScriptFrontendRendering
middleware hold a reference to the outer TSFE instance which
contains the original page id.

Instead of injecting the stateful TSFE (which is generally discouraged),
TSFE in now passed as request attribute. The container will
log an according warning message from now on.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4