Review main Merged

71113[BUGFIX] Clone PageLayoutContext for correct language

Oli Bartsch CR +2 V +2 Easy +14 −1 updated 09/17/21, 08:47

Commit message

In the fluid based page module, when in columns mode
and having a L>0 language selected, the context always
contained L=0 as the current site language. Since this
value is used in the fluid templates for data attributes
and similar, it might lead to unintended outcome.

This is now fixed by cloning the context for the currently
selected language before forwarding it to grid creation,
as it's already done in languages mode and for the special
"defLangBinding" view.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 09/17/21, 00:06

  2. core-ci voted on patch set 1 V +1 09/17/21, 00:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16844

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/17/21, 08:32

  4. Jochen Roth voted on patch set 1 V +1 CR +1 09/17/21, 08:46

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 09/17/21, 08:47

  6. Oli Bartsch merged patch set 2 09/17/21, 08:47