Review main Abandoned

71114[WIP][TASK] Add return types for internal / test methods

Benni Mack CR 0 V 0 Normal +39 −42 updated 11/04/21, 11:20

Commit message

This change eases the pain for updating to PHP 8 and Symfony 6
by using symfony/error-handler's "patch-type-declarations" solution.

See https://wouterj.nl/2021/09/symfony-6-native-typing for more details
on how this procedure works.

Used CLI call:
SYMFONY_PATCH_TYPE_DECLARATIONS="force=1&php=7.4" ./bin/patch-type-declarations

This change solely touches final and internal methods and thus
isn't intrusive unlike possible further changes.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 20